Revert cast formatting regression#17512
Merged
highker merged 5 commits intoprestodb:masterfrom Mar 24, 2022
asjadsyed:cast-formatting
Merged
Revert cast formatting regression#17512highker merged 5 commits intoprestodb:masterfrom asjadsyed:cast-formatting
highker merged 5 commits intoprestodb:masterfrom
asjadsyed:cast-formatting
Conversation
Contributor
|
cc @v-jizhang |
|
Can we open a ticket and move the context to a ticket? |
Contributor
|
My understanding is the problem wasn't that it's a regression (it's just a different way of displaying the same answer), but that the different display prevents us from easily comparing results with older versions to ensure there are no regressions, which is why we need a flag. |
Contributor
|
Release note is not required for this. |
highker
approved these changes
Mar 24, 2022
|
Ticket #17522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #17522